On Wed, Jan 12, 2011 at 09:24:37PM +0800, Ming Lei wrote: > Hi, > > 2011/1/12 Felipe Balbi <balbi@xxxxxx>: > > Hi Sergei, > > > > on DaVinci is extremely necessary to program EP CSR before > > channel_program() ? I believe it's not a problem for the OMAP-based > > board and I doubt it's a problem for Blackfin too. > > > > I think it would be easy to drop all the DMA magic if we figure out a > > way to program DMA that works for all engines. Possibly following what > > MUSB docs say would be enough: > > > > . Program EP CSR > > . Program DMA ADDR and COUNT > > . Program DMA Control > > > > So it would be something like: > > > > From 586d9ea1b0417640877c201fdb88d2d555b8c174 Mon Sep 17 00:00:00 2001 > > From: Felipe Balbi <balbi@xxxxxx> > > Date: Wed, 12 Jan 2011 12:50:24 +0200 > > Subject: [PATCH] usb: musb: gadget: drop DMA ifdeffery > > Organization: Texas Instruments\n > > > > MUSB DMA programming can be done in a simpler > > way if we drop all the DMA magic. > > > > NYET-Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > > > Completely untested, just looking at the code. Didn't even compile this > > one. > > Suggest you do the cleanup against usb-next branch of your tree, > my musb cleanup patchset has removed all ifdef already. > > Also, does it make sense for a non-compile and non-tested patch? it's a "patch" yet, just asking Sergei if he thinks it'll work on DaVinci. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
