On Tue, Jan 11, 2011 at 02:01:25PM -0500, Alan Stern wrote: > On Tue, 11 Jan 2011, Greg KH wrote: > > > > > Ick, good point. I could just change the usb_register() to force the > > > > usb_driver field to be the option to that function, which would force it > > > > to be set. > > > > > > > > Would that make it easier or just be a pain? > > > > > > I suspect it would just be a pain. It would mean editing _all_ the > > > serial drivers, as opposed to fixing only the ones listed above. > > > > That's not a real problem, multiple file edits are easy :) > > > > > I'll write a patch fixing the remaining drivers and adding a WARN (not > > > a BUG) plus an error return to usb_serial_register() if the field isn't > > > set. > > > > Ok, that's good enough for now. It looks like it is also needed in the > > .37 kernel, how about anything earlier than that? > > The issue Dan ran into doesn't affect kernels before 2.6.37. Of > course, without the .usb_driver field set, people can't add dynamic IDs > to those drivers. Yeah, so it would be good to get that fixed in older kernels as well, I'll queue it up for them too. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
