On Tue, 11 Jan 2011, Greg KH wrote: > > No, that's not the problem. The problem is that qcaux.c does not > > define the .usb_driver field in its qcaux_device structure. > > > > Hmm, it looks like the same bug is present for the epic_device > > structure in io_tables.h, and in iuu_phoenix.c, keyspan.h, > > moto_modem.c, oti6858.c, siemens_mpi.c, spcp8x5.c, and usb_debug.c. > > Maybe it would be a good idea to replace the test in > > usb_serial_register() for this field being non-NULL with a BUG. That > > would draw people's attention! > > Ick, good point. I could just change the usb_register() to force the > usb_driver field to be the option to that function, which would force it > to be set. > > Would that make it easier or just be a pain? I suspect it would just be a pain. It would mean editing _all_ the serial drivers, as opposed to fixing only the ones listed above. I'll write a patch fixing the remaining drivers and adding a WARN (not a BUG) plus an error return to usb_serial_register() if the field isn't set. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html