Re: [PATCH 046/144] usbmon: correct length for isochronous

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 6 Jan 2011, Greg Kroah-Hartman wrote:

> From: Pete Zaitcev <zaitcev@xxxxxxxxxx>
> 
> Usually the usbmon returns the amount of data specified in
> urb->transfer_buffer_length for output submissions and urb->actual_length
> for input callbacks. However, for Isochronous input transfers, this is
> not enough, since the returned data buffer may contain "holes".
> 
> One easy way to fix this is to use urb->transfer_buffer_length,
> but this often transfers a whole lot of unused data, so we find
> how much was actually used instead.

This is the patch I mentioned yesterday.  It changes an established
kernel/userspace ABI, so I recommend that it be reverted and replaced 
by the patch posted in

	http://marc.info/?l=linux-usb&m=129424577426130&w=2

In effect, don't worry about transferring a whole lot of unused data, 
since that's what userspace has learned to expect.  Just do it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux