Hi! >>>>> ext David Brownell writes: > > Date: Thursday, January 6, 2011, 3:50 PM > > From: Yauheni Kaliuta <yauheni.kaliuta@xxxxxxxxx> > > > > +/* DO NOT REUSE THESE IDs with a protocol-incompatible > > driver!! Ever!! > Grr. It seems that's exactly what this does. Yes, my fault. > You're using the CDC ECM Id for everything, which > is (as it says) *VERY* incorrect. > Methinks each of g_ncm, g_eem, and g_cdc (ecm?) > lso g > should have their own source file, own Kconfig > engry,and own product Ids... Use the Linux-USB > vendor ID. except where IDs are already assigned. > and valid... > > + * Instead: allocate your own, using normal USB-IF procedures. > which in this case involve going through Greg... > > + */ > > + > > +/* Thanks to NetChip Technologies for donating this > > product ID. > > + * It's for devices with only CDC Ethernet > > configurations. > HIGHLIGHT!!!!! NOT NCM!! NCM is more or less CDC Ethernet as well. But this gadget is definitely different so should have a different ID. [...] > >   = "CDC Ethernet (NCM)", > No, theses IDs and strings areor ECM not NCM. I concidered NCM as an ECM extention, it even reuses its descriptor. [...] -- WBR, Yauheni Kaliuta -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
