Re: [PATCH] usb: otg: nop: fix oops triggered by otg_register_notifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Add  Gupta

2011/1/4  <tom.leiming@xxxxxxxxx>:
> From: Ming Lei <tom.leiming@xxxxxxxxx>
>
> This patch adds BLOCKING_INIT_NOTIFIER_HEAD in nop_usb_xceiv_probe,
> so that we can avoid oops caused by uninitialized
> nop->otg.notifier.rwsem which will be touched in otg_register_notifier
> path.
>
> Reported-by: Gupta, Ajay Kumar <ajay.gupta@xxxxxx>
> Tested-by: Gupta, Ajay Kumar <ajay.gupta@xxxxxx>
> Cc: Balbi, Felipe <balbi@xxxxxx>
> Cc: David Brownell <david-b@xxxxxxxxxxx>
> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
> ---
>  drivers/usb/otg/nop-usb-xceiv.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c
> index e70014a..8acf165 100644
> --- a/drivers/usb/otg/nop-usb-xceiv.c
> +++ b/drivers/usb/otg/nop-usb-xceiv.c
> @@ -132,6 +132,8 @@ static int __devinit nop_usb_xceiv_probe(struct platform_device *pdev)
>
>        platform_set_drvdata(pdev, nop);
>
> +       BLOCKING_INIT_NOTIFIER_HEAD(&nop->otg.notifier);
> +
>        return 0;
>  exit:
>        kfree(nop);
> --
> 1.7.3
>
>


thanks,
-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux