On Mon, Dec 20, 2010 at 04:48:54PM +0100, Arnaud Patard wrote: > vbus should be enabled after usb_add_hcd() otherwise USB is not working > on my efikamx. I have tested this on different i.MX27/31/35 based boards, the USB is still functional, so Tested-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Signed-off-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx> > Index: tst-usb/drivers/usb/host/ehci-mxc.c > =================================================================== > --- tst-usb.orig/drivers/usb/host/ehci-mxc.c 2010-12-20 15:38:41.000000000 +0100 > +++ tst-usb/drivers/usb/host/ehci-mxc.c 2010-12-20 15:38:43.000000000 +0100 > @@ -210,11 +210,6 @@ > ret = -ENODEV; > goto err_add; > } > - ret = otg_set_vbus(pdata->otg, 1); > - if (ret) { > - dev_err(dev, "unable to enable vbus on transceiver\n"); > - goto err_add; > - } > } > > priv->hcd = hcd; > @@ -224,6 +219,14 @@ > if (ret) > goto err_add; > > + if (pdata->otg) { > + ret = otg_set_vbus(pdata->otg, 1); > + if (ret) { > + dev_err(dev, "unable to enable vbus on transceiver\n"); > + goto err_add; > + } > + } > + > return 0; > > err_add: > > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html