Re: [RFC 22/22] usb: Disable auto-suspend for USB 3.0 hubs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 30 Dec 2010, Sarah Sharp wrote:

> USB 3.0 devices have a slightly different suspend sequence than USB
> 2.0/1.1 devices.  There isn't support for USB 3.0 device suspend yet, so
> make khubd leave autosuspend disabled for USB 3.0 hubs.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/core/hub.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 8a5ea2b..aca1cce 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1288,8 +1288,13 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  	desc = intf->cur_altsetting;
>  	hdev = interface_to_usbdev(intf);
>  
> -	/* Hubs have proper suspend/resume support */
> -	usb_enable_autosuspend(hdev);
> +	/* Hubs have proper suspend/resume support.  USB 3.0 device suspend
> +	 * is different than USB 2.0/1.1 device suspend, and unfortunately we

s/different than/different from/  (and likewise in the patch 
description)

> +	 * don't support it yet.  So leave autosuspend disabled that for

s/disabled that/disabled/

> +	 * USB 3.0 hubs for now.
> +	 */
> +	if (!hub_is_superspeed(hdev))
> +		usb_enable_autosuspend(hdev);

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux