On Mon, Dec 27, 2010 at 09:12:05PM +0100, Rafael J. Wysocki wrote: > On Monday, December 27, 2010, Sarah Sharp wrote: > > On Mon, Dec 27, 2010 at 07:57:23PM +0100, Rafael J. Wysocki wrote: > > > On Monday, December 27, 2010, Sarah Sharp wrote: > > > > On Mon, Dec 27, 2010 at 02:14:56PM +0100, Rafael J. Wysocki wrote: > > > > > On Monday, December 27, 2010, Andiry Xu wrote: > > > > > > Synchronize the interrupts instead of free them in xhci_suspend(). This will > > > > > > prevent a double free when the host is suspended and then the card removed. > > > > > > > > > > > > Set the flag hcd->msix_enabled when using MSI-X, and check the flag in > > > > > > suspend_common(). MSI-X synchronization will be handled by xhci_suspend(), > > > > > > and MSI/INTx will be synchronized in suspend_common(). > > > > > > > > > > > > Reported-by: Matthew Garrett <mjg@xxxxxxxxxx> > > > > > > Signed-off-by: Andiry Xu <andiry.xu@xxxxxxx> > > > > > > > > > > Looks good, but you need to remove the xhci_cleanup_msix() from under > > > > > the spinlock in _stop() and _shutdown() too. > > > > > > > > There's a separate patch submitted by someone else to do that. I'll > > > > take this patch and work out the conflicts. > > > > > > Well, that was probably me. Anyway, the patch is appended. Please use it if > > > this is the right thing to do here. > > > > Actually, it was submitted by Zhang Rui on Dec 17. Good to have lots of > > people catching the same bug though. :) > > Yeah, but on the other hand we could avoid losing time on fixing the same > problem multiple times if the fixes were pushed upstream more aggressively. Point. I'm still getting used to sending Greg pull requests (versus straight patches), and I've been tending to wait until I have a couple bug fixes, if I know a rev of a patch is pending. I will attempt to send patches upstream as soon as they're stable, even if it means sending Greg a one-patch pull request, followed the next day by another one-patch pull request. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
