2010/12/13 Felipe Balbi <balbi@xxxxxx>:
> Hi,
>
> On Mon, Dec 13, 2010 at 04:00:03PM +0300, Sergei Shtylyov wrote:
>>>
>>> Sorry, could you explain it in more detail so that I can grasp your idea?
>>
>> The #if's will have to grow each time the new DMA engine is added. In
>> fact, I don't see why this patch is even necessary.
>
> I agree with you here Sergei. It's better to just split the thing to its
> own platform driver and remove all ifdeferry on DMA usage.
As I said to Felipe in another mail, the final goal is to remove this helpers
and move all dma specific things into dma controller driver, make musb_hdrc
independent on specific dma controller.
But seems there are a not short-road to reach the goal, musb code
(musb_core.c/musb_host.c/musb_gadget.c) are very closely coupled with
specific DMA controller by the config options below and the
helpers(is_cppi_enabled/tusb_dma_omap):
CONFIG_USB_INVENTRA_DMA
CONFIG_USB_TI_CPPI_DMA
CONFIG_USB_TUSB_OMAP_DMA
This patch set removes all dependency on the three config options in source
code and convert them into the three helpers. We have gone ahead towards
the final goal since removing the helpers and converting dma-specific code
into dma controller will be more easily than before after all config options
have been killed.
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
