On Fri, Dec 10, 2010 at 02:18:44PM +0800, Xu, Andiry wrote: > > -----Original Message----- > > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > > Andiry, > > > > Can you take a look at this? The USB core relies on not having more > > than USB_MAXCHILDREN ports in many different places, so I think this > > simplification won't change any current behavior. Do you have any > > objections? > > > > The patch looks OK and it really simplifies the code, I've no > objections. Please note there is a code in xhci_mem_init(): > > + for (i = 0; i < MAX_HC_PORTS; ++i) > + xhci->resume_done[i] = 0; > > Please also change the MAX_HC_PORTS to USB_MAXCHILDREN, or you will > access memory out of the array. Ah, yes, good catch. I had that in a later patch in the split roothub series, but I didn't include it in this patch. I'll fix it. Sarah -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
