Re: [PATCH 4/5 v4] OMAP2+: musb: HWMOD adaptation for musb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2010 at 6:32 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Fri, Dec 10, 2010 at 06:23:10PM +0530, Hema HK wrote:
>>
>> @@ -212,8 +228,28 @@ void __init usb_musb_init(struct omap_mu
>>        musb_plat.mode = board_data->mode;
>>        musb_plat.extvbus = board_data->extvbus;
>>
>> -       if (platform_device_register(&musb_device) < 0)
>> -               printk(KERN_ERR "Unable to register HS-USB (MUSB)
>> device\n");
>> +       if (cpu_is_omap3517() || cpu_is_omap3505()) {
>> +
>> +               if (platform_device_register(&musb_device) < 0)
>> +                       printk(KERN_ERR "Unable to register HS-USB \
>> +                                       (MUSB) device\n");
>> +       } else {
>
> you can amend these two branches to the previous one. move the
> platform_device_register() to the previous if (cpu_is_omap3517() ||
> cpu_is_omap3505()) check. similarly with the code below.

Yes... Can be done.

Regards,
Hema
>
>> +               pdata = &musb_plat;
>> +               od = omap_device_build(name, bus_id, oh, pdata,
>> +                                      sizeof(*pdata), omap_musb_latency,
>> +                                      ARRAY_SIZE(omap_musb_latency),
>> false);
>> +               if (IS_ERR(od)) {
>> +                       pr_err("Could not build omap_device for %s %s\n",
>> +                                                       name, oh_name);
>> +                       return;
>> +               }
>> +               pdev = &od->pdev;
>> +               dev = &pdev->dev;
>> +               get_device(dev);
>> +               dev->dma_mask = &musb_dmamask;
>> +               dev->coherent_dma_mask = musb_dmamask;
>> +               put_device(dev);
>> +       }
>> }
>>
>> #else
>
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux