Re: [PATCH v4] usb: musb: Adding names for IRQs in resource structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2010 at 6:26 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> On 10-12-2010 7:46, Kalliguddi, Hema wrote:
>
>>>>> The resource data is getting automatically populated from a set of data
>>>>> generated from TI's hardware database for the OMAP platform, While we
>>>>> could hack in some exceptions to that tool to generate resources
>>>>> in a specific order, it seems less fragile to use the resource name
>>>>> instead.That way, no matter what order the resources are generated, the
>>>>> driver still work.
>
>>>>> Modified the OMAP,Blackfin and Davinci architecture files to add the
>>>>> name
>>>>> of the IRQs
>>>>> in the resource structures and musb driver to use the get_irq_byname()
>>>>> api to
>>>>> get the device and dma irq numbers instead of using the index.
>
>>>>> Signed-off-by: Hema HK<hemahk@xxxxxx>
>>>>> Cc: Felipe Balbi<balbi@xxxxxx>
>>>>> Cc: Tony Lindgren<tony@xxxxxxxxxxx>
>>>>> Cc: Kevin Hilman<khilman@xxxxxxxxxxxxxxxxxxx>
>>>>> Cc: Cousson, Benoit<b-cousson@xxxxxx>
>>>>> Cc: Paul Walmsley<paul@xxxxxxxxx>
>>>>> Cc: Mike Frysinger<vapier@xxxxxxxxxx>
>>>>> ---
>
>>>> For the davinci changes:
>
>>>> Acked-by: Kevin Hilman<khilman@xxxxxxxxxxxxxxxxxxx>
>
>>>> Kevin
>
>>> [...]
>
>>>>> Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>> ===================================================================
>>>>> --- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
>>>>> +++ linux-omap-pm/arch/arm/mach-davinci/usb.c
>>>>> @@ -64,10 +64,12 @@ static struct resource usb_resources[] =
>>>>>        {
>>>>>                .start          = IRQ_USBINT,
>>>>>                .flags          = IORESOURCE_IRQ,
>>>>> +               .name           = "mc"
>>>>>        },
>>>>>        {
>>>>>                /* placeholder for the dedicated CPPI IRQ */
>>>>>                .flags          = IORESOURCE_IRQ,
>>>>> +               .name           = "dma"
>>>>>        },
>>>>>  };
>
>>>   Argh! This failed to also modify da8xx_usb20_resources[]... :-(
>
>> I think when I posted these patch, da8xx support was not there in
>> mainline.
>
>   No, it was added long ago, before the glue layer itself.
>
>> I will send patch to add this.
>
>   I will care about this myself now.
Thanks.
Hema
>
>> Regards,
>> Hema
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux