On Fri, Dec 10, 2010 at 4:00 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Fri, Dec 10, 2010 at 12:34:50PM +0530, Hema HK wrote:
>>
>> Registering the twl6030-usb transceiver device as a child to twl6030 core.
>> Removed the NOP transceiver init call from board file.
>>
>> Populated twl4030_usb_data platform data structure with the function
>> pointers for OMAP4430 internal PHY operation to be used by twl630-usb
>> driver.
>>
>>
>
> one blank line only.
OK. I will fix it
>
>> Index: usb/include/linux/i2c/twl.h
>> ===================================================================
>> --- usb.orig/include/linux/i2c/twl.h
>> +++ usb/include/linux/i2c/twl.h
>> @@ -593,6 +593,13 @@ enum twl4030_usb_mode {
>>
>> struct twl4030_usb_data {
>> enum twl4030_usb_mode usb_mode;
>> +
>> + int (*phy_init)(struct device *dev);
>> + int (*phy_exit)(struct device *dev);
>> + /* Power on/off the PHY */
>> + int (*phy_power)(struct device *dev, int iD, int on);
>> + /* enable/disable phy clocks */
>> + int (*phy_set_clock)(struct device *dev, int on);
>> };
>
> This hunk should come either before or together with patch:
>
Agree this patch should be before 4th patch.
> usb: otg: Adding twl6030-usb transceiver driver for
>
>> struct twl4030_ins {
>> Index: usb/arch/arm/mach-omap2/board-omap4panda.c
>> ===================================================================
>> --- usb.orig/arch/arm/mach-omap2/board-omap4panda.c
>> +++ usb/arch/arm/mach-omap2/board-omap4panda.c
>> @@ -137,6 +137,13 @@ static struct omap_musb_board_data musb_
>> .power = 100,
>> };
>>
>> +static struct twl4030_usb_data omap4_usbphy_data = {
>> + .phy_init = omap4430_phy_init,
>> + .phy_exit = omap4430_phy_exit,
>> + .phy_power = omap4430_phy_power,
>> + .phy_set_clock = omap4430_phy_set_clk,
>> +};
>> +
>> static struct omap2_hsmmc_info mmc[] = {
>> {
>> .mmc = 1,
>> @@ -345,6 +352,7 @@ static struct twl4030_platform_data omap
>> .vaux1 = &omap4_panda_vaux1,
>> .vaux2 = &omap4_panda_vaux2,
>> .vaux3 = &omap4_panda_vaux3,
>> + .usb = &omap4_usbphy_data,
>> };
>>
>> static struct i2c_board_info __initdata omap4_panda_i2c_boardinfo[] = {
>
> This hunk should come before adding the Kconfig entries for twl6030-usb.
Agree. I will correct it submit in sometime.
Regards,
Hema
>
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
