Hi,
On Thu, Dec 09, 2010 at 03:49:27PM +0200, Felipe Balbi wrote:
On Thu, Dec 09, 2010 at 04:45:41PM +0300, Sergei Shtylyov wrote:
@@ -205,7 +231,7 @@ static int omap2430_musb_init(struct musb *musb)
return -ENODEV;
}
- omap2430_musb_resume(musb);
+ omap2430_low_level_init(musb);
Wait! omap2430_musb_resume() disabled wakeup and MSTANDBY, while
omap2430_low_level_init() enables them... :-/
l = musb_readl(musb->mregs, OTG_SYSCONFIG);
l &= ~ENABLEWAKEUP; /* disable wakeup */
Why disable what's already disabled?
Yeah, Hema told me about this a few minutes ago. Apparently I mistakenly
put omap2430_musb_resume() code into suspend path and vice-versa.
I'll change the branch tomorrow. Thanks both of you for the note.
+ omap2430_restore_context(musb);
+ otg_set_suspend(musb->xceiv, 0);
+
+ return 0;
+}
+
+static struct dev_pm_ops omap2430_pm_ops = {
+ .suspend = omap2430_suspend,
+ .resume = omap2430_resume,
+};
+
+#define DEV_PM_OPS &omap2430_pm_ops
I've just read this should be giving scripts/checkpatch.pl error
without parens...
I'll add update this one also :-)
Actually already done.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
