Hi,
other than a few comments below, it's great :-)
On Thu, Dec 09, 2010 at 11:15:58AM +0100, Mian Yousaf Kaukab wrote:
+static void ux500_musb_set_vbus(struct musb *musb, int is_on)
+{
+ /* TODO */
+}
+
+static int ux500_musb_set_mode(struct musb *musb, u8 musb_mode)
+{
+ return -EIO;
+}
you can remove the nops, if you look at the header file you'll see it
will work without these :-)
+static int __init ux500_probe(struct platform_device *pdev)
+{
+ struct musb_hdrc_platform_data *pdata = pdev->dev.platform_data;
+ struct platform_device *musb;
+ struct ux500_glue *glue;
+ struct clk *clk;
+
+ int ret = -ENOMEM;
+
+ glue = kzalloc(sizeof(*glue), GFP_KERNEL);
+ if (!glue) {
+ dev_err(&pdev->dev, "failed to allocate glue context\n");
+ goto err0;
+ }
+
+ musb = platform_device_alloc("musb-hdrc", -1);
+ if (!musb) {
+ dev_err(&pdev->dev, "failed to allocate musb device\n");
+ goto err1;
+ }
+
+ clk = clk_get(&pdev->dev, pdata->clock);
don't pass clock names around, we want to get rid of that :-)
Russell King has had great comments about not relying on clocks names
and how people are mis-using the clk API.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
