Hello.
Mian Yousaf Kaukab wrote:
You probably copied this from omap2430.c?
Yes.
This is incorrect way of inplemeting this method.
Ok, I was letting the the connector chose the mode.
You are explicitly passed the 'mode' argument, you can't choose it at
connector's discretion.
See drivers/usb/musb/da8xx.c for the correct one. The
method should enforce host/gadget/OTG mode.
You can also see tusb6010.c -- here only the ID pin is overridden.
It looks like da8xx is overriding the comparators and so. Is it what
enforcing meant here?
Overriding VBUS comparator is a DA8xx specific side effect of overriding the
ID pin -- you just can't do it otherwise.
Or the driver should only allow the
desired mode, but should wait for the proper conditions as well. For
example, if desired mode is MUSB_PERIPHERAL,
wait till VBUS is valid and in the mean time ignore ID ground event if
you get it.
No, you should not wait for anything as far as I understand. Let Felipe
clarify this if he wants...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
