Hello.
On 07-12-2010 19:28, Richard RÃjfors wrote:
Building pch_udc in linux-next fails, this patch fixes the a compile
error:
drivers/usb/gadget/pch_udc.c: In function âusb_gadget_register_driverâ:
drivers/usb/gadget/pch_udc.c:2645: error: âstruct usb_gadget_driverâ has no member named âbindâ
drivers/usb/gadget/pch_udc.c:2664: error: âstruct usb_gadget_driverâ has no member named âbindâ
And a couple of compiler warnings
Why not cite them as well?
and checkpatch warnings.
It would have been better to fix the checkpatch warnings in a sperate
patch, I think...
Signed-off-by: Richard RÃjfors <richard.rojfors@xxxxxxxxxxxxxx>
---
diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
index 4a52569..216f648 100644
--- a/drivers/usb/gadget/pch_udc.c
+++ b/drivers/usb/gadget/pch_udc.c
@@ -337,7 +337,7 @@ struct pch_udc_dev {
struct usb_gadget_driver *driver;
struct pci_dev *pdev;
struct pch_udc_ep ep[PCH_UDC_EP_NUM];
- spinlock_t lock;
+ spinlock_t lock; /* protects all state */
Hardly a fix for anything...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
