Re: [PATCH 1/1]usb: check NULL stream pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 07, 2010 at 02:58:39PM +0800, Jun Nie wrote:
> >From 109b59f272890bcc662f1bdf22175eba489f4a48 Mon Sep 17 00:00:00 2001
> From: Jun Nie <njun@xxxxxxxxxxx>
> Date: Tue, 7 Dec 2010 14:00:55 +0800
> Subject: [PATCH] usb: fix stream reference after it is freed
> 
> Signed-off-by: Jun Nie <njun@xxxxxxxxxxx>

I don't understand, why is this patch needed, and what does it do?

Please resend it, in a format I can apply (hint, don't put the whole
header again in the body of the email), and include a good changelog
comment describing exactly why this patch is needed and what it does.

> +	if (1 == stream->refcount)

Also, please reverse these values, the compiler will tell you if you
accidentally get it wrong, so there is no need for you to try to be
smarter than it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux