Hello.
On 06-12-2010 15:13, Felipe Balbi wrote:
... then we don't need to export any symbols
from glue layer to musb_core.
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
[...]
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
index 120fc9e..de18da6 100644
--- a/drivers/usb/musb/am35x.c
+++ b/drivers/usb/musb/am35x.c
@@ -530,7 +530,7 @@ void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
}
}
-const struct musb_platform_ops musb_ops = {
+static const struct musb_platform_ops musb_ops = {
You forgot to rename it?
.init = am35x_musb_init,
.exit = am35x_musb_exit,
@@ -572,6 +572,8 @@ static int __init am35x_probe(struct platform_device *pdev)
glue->dev =&pdev->dev;
glue->musb = musb;
+ pdata->platform_ops = &am35x_ops;
Looks like you didn't try to compile this...
diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
index 6672ed0..2434f20 100644
--- a/drivers/usb/musb/blackfin.c
+++ b/drivers/usb/musb/blackfin.c
@@ -438,7 +438,7 @@ static int bfin_musb_exit(struct musb *musb)
return 0;
}
-const struct musb_platform_ops musb_ops = {
+static const struct musb_platform_ops musb_ops = {
You forgot to rename it?
@@ -481,6 +481,8 @@ static int __init bfin_probe(struct platform_device *pdev)
glue->dev =&pdev->dev;
glue->musb = musb;
+ pdata->platform_ops =&bfin_ops;
Looks like you didn't try to compile this...
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index 68c17e4..72db653 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -475,7 +475,7 @@ static int da8xx_musb_exit(struct musb *musb)
return 0;
}
-const struct musb_platform_ops musb_ops = {
+static const struct musb_platform_ops musb_ops = {
You forgot to rename it?
@@ -517,6 +517,8 @@ static int __init da8xx_probe(struct platform_device *pdev)
glue->dev =&pdev->dev;
glue->musb = musb;
+ pdata->platform_ops = &da8xx_ops;
Looks like you didn't try to compile this...
diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
index 1106599..c8d2d40 100644
--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -510,7 +510,7 @@ static int davinci_musb_exit(struct musb *musb)
return 0;
}
-const struct musb_platform_ops musb_ops = {
+static const struct musb_platform_ops musb_ops = {
You forgot to rename it?
@@ -551,6 +551,8 @@ static int __init davinci_probe(struct platform_device *pdev)
glue->dev =&pdev->dev;
glue->musb = musb;
+ pdata->platform_ops = &davinci_ops;
Looks like you didn't try to compile this...
diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb/musb/tusb6010.c
index e322b41..cba6c6e 100644
--- a/drivers/usb/musb/tusb6010.c
+++ b/drivers/usb/musb/tusb6010.c
@@ -1178,7 +1178,7 @@ static int tusb_musb_exit(struct musb *musb)
return 0;
}
-const struct musb_platform_ops musb_ops = {
+static const struct musb_platform_ops musb_ops = {
You forgot to rename it?
@@ -1221,6 +1221,8 @@ static int __init tusb_probe(struct platform_device *pdev)
glue->dev =&pdev->dev;
glue->musb = musb;
+ pdata->platform_ops = &tusb_ops;
Looks like you didn't try to compile this...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
