On Sun, Dec 5, 2010 at 23:17, Dan Williams <dcbw@xxxxxxxxxx> wrote: > The ATM subsystem was incorrectly creating the 'device' link for ATM > nodes in sysfs. ÂThis led to incorrect device/parent relationships > exposed by sysfs and udev. ÂInstead of rolling the 'device' link by hand > in the generic ATM code, pass each ATM driver's bus device down to the > sysfs code and let sysfs do this stuff correctly. Looks good to me. It's wrong for any subsystem to ever create a file or link named "device". It's a built-in driver-core managed property which appears automatically as soon as the parent-device relations are correctly established. Udev/libudev intentionally refuses to follow any devices pointed to by "broken" device links. So this patch is needed to make ATM devices working properly with usual userspace tools. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html