Re: [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Anand Gadiyar <gadiyar@xxxxxx> [101130 13:56]:
> On 12/1/2010 3:10 AM, Tony Lindgren wrote:
> > * Anand Gadiyar <gadiyar@xxxxxx> [101129 09:16]:
> >> - Add platform init code for EHCI on OMAP4
> >> - Add pad configuration for PHY and TLL modes
> >>
> >> Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
> > 
> > Looks OK to me. You might want to check if all these signals
> > are unique though and do not have alternate paths.
> > 
> > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> I've checked these manually - for EHCI, all signals are unique
> and come out on exactly one pad. With OHCI though, there are
> alternates for 3 signals of one port.

OK
 
> Also, with the mux framework, it tells us if there are
> duplicates and the framework cannot identify the pad from
> the signal name alone.

Yes I posted a series of patches showing how we can pass
the board specific pin configuration to the platform init
code, so that can be done for the OHCI pins later on.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux