On Fri, Dec 03, 2010 at 01:06:56PM -0800, Sarah Sharp wrote: > On Fri, Dec 03, 2010 at 12:37:07PM -0800, Greg KH wrote: > > On Fri, Dec 03, 2010 at 12:29:00PM -0800, Sarah Sharp wrote: > > > lsusb doesn't compile for me unless I add this header file. This is an > > > older development system (Ubuntu 9.04), so I'm not sure what combo of dev > > > packages is to blame. > > > > > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > > > --- > > > usbmisc.c | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/usbmisc.c b/usbmisc.c > > > index bafb623..ee7f413 100644 > > > --- a/usbmisc.c > > > +++ b/usbmisc.c > > > @@ -30,6 +30,7 @@ > > > #include <stdio.h> > > > #include <string.h> > > > #include <unistd.h> > > > +#include <linux/limits.h> > > > > Odd, what is the error you are getting without this header file being > > included? > > sarah@broadway:~/git/usbutils$ make lsusb > gcc -DHAVE_CONFIG_H -I. -I/usr/include/libusb-1.0 -DDATADIR=\"/usr/share\" -g -O2 -MT lsusb-usbmisc.o -MD -MP -MF .deps/lsusb-usbmisc.Tpo -c -o lsusb-usbmisc.o `test -f 'usbmisc.c' || echo './'`usbmisc.c > usbmisc.c: In function âreadlink_recursiveâ: > usbmisc.c:44: error: âPATH_MAXâ undeclared (first use in this function) > usbmisc.c:44: error: (Each undeclared identifier is reported only once > usbmisc.c:44: error: for each function it appears in.) > usbmisc.c: In function âget_usb_deviceâ: > usbmisc.c:127: error: âPATH_MAXâ undeclared (first use in this function) > make: *** [lsusb-usbmisc.o] Error 1 Odd, ok, we need that so I'll include your patch, wierd that it built at all without it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
