> >We already have generic APIs so I think we can pass function pointers to
> >musb driver via "struct omap_musb_board_data",
> >
> > struct omap_musb_board_data {
> >+ void (*phy_on) (void)
> >+ void (*phy_off) (void)
> >+ void (*intr_clr) (void)
> > }
> >
> >Reset part can be done in board file itself same as Ethernet driver is
> doing.
> >
> >Does this look fine?
>
> so those would be "turn phy on", "turn phy off" and "clear interrupt"
> apis ?
>
> How about:
> int (*set_phy_power)(unsigned on);
Looks good.
> void (*clear_phy_irq)(void);
This is actually musb ip interrupt clear so I will make it like,
void (*clear_irq) (void);
>
> You'd need one less API for that. BTW, could you do it on top of my
> musb-hw branch ? Then I can push together with those for merge window.
Not yet, I will send once completed.
Thanks,
Ajay
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
