>>> >need events like HNP FAILED, No response for HNP enable request, and NOT >>> >found in TPL etc. So I prefer >>> >to define an enum for OTG event instead of using USB_DEVICE_ADD and >>> >USB_DEVICE_REMOVE. >> Actually I have defined some OTG events in linux/usb/intel_mid_otg.h, they are used >in intel langwell/penwell otg_transceiver driver. >> I think I can purpose them for common usage, only minor concern here is that maybe >different platforms/otg implementations may need different events to be defined. >> > >I think, we should limit them to OTG spec events which are required to >transition states, >start/stop timers and user space notifications like the B-device is not >in TPL, HUB class >not supported, HNP available etc Thanks for your suggestion, start/stop timers events are not needed in langwell/penwell_otg implementation. and more other events needed, e.g ,event for USB charging from udc according to Battery charging spec 1.1. Anyway, I will purpose my events list for review later. : ) One more question that, do you have any suggestion on the implementation for user space notification("No silent failures")? I think only printk some warnings seems not good enough. Thanks in advance. Hao -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html