On Thu, Dec 02, 2010 at 02:45:27AM +0900, Namhyung Kim wrote: > Since whci_hcd_id_table is used only for module auto-loading > move it under #ifdef MODULE. This fixes following warning: > > CC drivers/usb/host/whci/hcd.o > drivers/usb/host/whci/hcd.c:359: warning: âwhci_hcd_id_tableâ defined but not used > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx> > --- > drivers/usb/host/whci/hcd.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c > index 72b6892..ee76401 100644 > --- a/drivers/usb/host/whci/hcd.c > +++ b/drivers/usb/host/whci/hcd.c > @@ -355,12 +355,14 @@ static void __exit whci_hc_driver_exit(void) > } > module_exit(whci_hc_driver_exit); > > +#ifdef MODULE Ick, no, please just use the __used type instead. We don't want #ifdefs in .c files if at all possible. Same goes for the other 2 patches, care to redo them as well? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
