Re: [RFC 01/15] USB 3.0 Hub Changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 30, 2010 at 06:33:06PM +0800, Ming Lei wrote:
> 2010/11/30 Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>:
> >  include/linux/usb/ch11.h         |   41 +++++++++++++++++++--
> 
> drivers/usb/musb/musb_virthub.c is missed.

Thanks, I'll fix that.

> >  16 files changed, 136 insertions(+), 46 deletions(-)
> >
> > diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
> > index 832608d..7ec3e74 100644
> > --- a/drivers/staging/usbip/vhci_hcd.c
> > +++ b/drivers/staging/usbip/vhci_hcd.c
> > @@ -257,8 +257,8 @@ static inline void hub_descriptor(struct usb_hub_descriptor *desc)
> >        desc->wHubCharacteristics = (__force __u16)
> >                (__constant_cpu_to_le16(0x0001));
> >        desc->bNbrPorts = VHCI_NPORTS;
> > -       desc->bitmap[0] = 0xff;
> > -       desc->bitmap[1] = 0xff;
> > +       desc->u.hs.bitmap[0] = 0xff;
> > +       desc->u.hs.bitmap[1] = 0xff;
> 
> Maybe redefining bitmap as u.hs.bitmap is cleverer fix, isn't it?

Redefining a misleading #define?  Ohh, that's evilly clever.  I like it. :)

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux