2010/11/27 Arnd Bergmann <arnd@xxxxxxxx>: > On Thursday 25 November 2010 18:16:13 Greg KH wrote: >> On Fri, Nov 26, 2010 at 01:11:05AM +0900, Tomoki Sekiyama wrote: >> > Hi Greg-KH, >> > Sorry for resending this; To: was not enough. >> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=23512 >> > >> > Default llseek operation behavior was changed by the patch named >> > "vfs: make no_llseek the default" after the yurex driver was merged, >> > so the llseek to yurex is now ignored. >> > >> > This patch add llseek fop with default_llseek to yurex driver >> > to catch up to the change. >> > >> > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxxxx> >> >> It's in my queue, sorry, been without power and water at home for a few >> days, will catch up on this stuff next week... > > I was out most of the week, so I didn't get to look at it either. > Is there an actual bug here caused by having no .llseek function? > > As far as I can tell, you don't really want to seek this file > anyway, so the default behaviour of disallowing llseek would actually > make more sense. I need seek because the device notifies the update of the sensor's value by fasync, then the user can rewind(seek to 0) and re-read the file. Thanks, -- Tomoki Sekiyama -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
