Re: [Uclinux-dist-devel] [PATCH v2] USB: musb: set NAK limitation for control transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 17, 2010 at 3:55 AM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> ping ...
> -mike
>
> On Fri, Aug 6, 2010 at 23:22, Mike Frysinger wrote:
>> From: Cliff Cai <cliff.cai@xxxxxxxxxx>
>>
>> Some bad-behaved peripherals (like cheap USB storage devices) need this in
>> order to recover during configuration time.
>>
>> Signed-off-by: Cliff Cai <cliff.cai@xxxxxxxxxx>
>> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
>> ---
>> v2
>> Â Â Â Â- tweak the delay based on the speed
>>
>> Âdrivers/usb/musb/musb_host.c | Â Â3 +++
>> Â1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
>> index 877d20b..64dd4ab 100644
>> --- a/drivers/usb/musb/musb_host.c
>> +++ b/drivers/usb/musb/musb_host.c
>> @@ -1994,6 +1994,9 @@ static int musb_urb_enqueue(
>> Â Â Â Â Â Â Â Â/* ISO always uses logarithmic encoding */
>> Â Â Â Â Â Â Â Âinterval = min_t(u8, epd->bInterval, 16);
>> Â Â Â Â Â Â Â Âbreak;
>> + Â Â Â case USB_ENDPOINT_XFER_CONTROL:
>> + Â Â Â Â Â Â Â interval = (urb->dev->speed == USB_SPEED_HIGH) ? 8 : 5;
>> + Â Â Â Â Â Â Â break;
>> Â Â Â Âdefault:
>> Â Â Â Â Â Â Â Â/* REVISIT we actually want to use NAK limits, hinting to the
>> Â Â Â Â Â Â Â Â * transfer scheduling logic to try some other qh, e.g. try
>> --
>> 1.7.2
>>

These days our test engineer found a problem that usb bluetooth dongle
can't be detected.
The link is: https://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_id=141&tracker_item_id=6366

And after I discarded this patch, the usb bluetooth dongle can be
detected and work fine.

So there need more work&test about this patch.

-- 
Thanks,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux