Re: [PATCH] SuperH on-chip EHCI glue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 25, 2010 at 10:46:04AM -0500, Alan Stern wrote:
> On Thu, 25 Nov 2010, Paul Mundt wrote:
> > +	.relinquish_port		= ehci_relinquish_port,
> > +	.port_handed_over		= ehci_port_handed_over,
> > +};
> 
> You are missing the .endpoint_reset and .ehci_clear_tt_buffer_complete 
> members.  This is a little surprising -- it implies the driver was 
> written by copying another one that didn't have these things, meaning 
> it must have been pretty old.
> 
I based it on ehci-atmel, which had a similar need for the clock
framework interfacing. I'll add in the two that you noticed, but if I'm
behind on some API changes, is there something else I should be looking
at?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux