On Thu, Nov 25, 2010 at 11:06:22PM +0800, Gavin Guo wrote: > > +static int ehci_port_change(struct ehci_hcd *ehci) > > +{ > > + int i = HCS_N_PORTS(ehci->hcs_params); > > + > > + while (i--) > > + if (ehci_readl(ehci, &ehci->regs->port_status[i]) & PORT_CSC) > > + return 1; > > + > > + return 0; > > +} > > Why only check the condition that only one port has changed the > status. Is it possible that many ports should change condition, but > only one reflect on port_status register ?? If any ports have changed we want to kick off the hub rediscovery process. I don't think the exact number of ports matter. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html