On Sat, Nov 20, 2010 at 7:05 PM, Piotr Isajew <pki@xxxxxxxxx> wrote:
> On Sat, Nov 20, 2010 at 11:01:44AM +0100, Johan Hovold wrote:
>> If the hso driver crashes this really needs to be fixed. Would you be
>> able to reproduce this and supply logs when running with debugging
>> enabled?
>
> First try on system without any traffic, no processes using modems:
>
> rmmod usbserial, then:
>
> # modprobe hso disable_net=1 debug=0x10
> Unicestwiony
> #
> Message from syslogd@katastrofa at Sat Nov 20 18:40:02 2010 ...
> katastrofa kernel: [1212701.666789] Oops: 0000 [#1] SMP
Can you try the attached patch and see if it helps?
Thanks,
Johan
>From f623d8fb01b581a82e7d032af32aa29815c1d79c Mon Sep 17 00:00:00 2001
From: Johan Hovold <jhovold@xxxxxxxxx>
Date: Wed, 24 Nov 2010 17:00:00 +0100
Subject: [PATCH] net: hso: fix crash when disable_net is set
When module parameter disable_net is set, a serial device is created
instead of a net device but hso_log_port still tries to access the
network device.
Compile-only tested.
Reported-by: Piotr Isajew <pki@xxxxxxxxx>
Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
---
drivers/net/usb/hso.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 1cd752f..bbb9cd7 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2151,7 +2151,8 @@ static void hso_log_port(struct hso_device *hso_dev)
port_type = "Unknown";
break;
}
- if ((hso_dev->port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK) {
+ if ((hso_dev->port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK &&
+ !disable_net) {
sprintf(port_dev, "%s", dev2net(hso_dev)->net->name);
} else
sprintf(port_dev, "/dev/%s%d", tty_filename,
--
1.7.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
