On Wed, 17 Nov 2010 15:29:47 +0300
Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> > + length = 0;
> > + fp = urb->iso_frame_desc;
> > + while (ndesc-- != 0) {
> > + if (fp->actual_length != 0) {
> > + if (fp->offset + fp->actual_length > length)
> > + length = fp->offset + fp->actual_length;
> > + }
>
> {} are not needed here, and thwo *if* statements can be collapsed into one.
They are semantically different and thus they were left uncollaplsed.
The upper one selects the descriptor and the lower own is an
open-coded min. Also, any collapsing would lead to hideously ugly
continuation lines.
> > + fp++;
>
> Could be a *for* loop instead...
The condition (ndesc) is different from the increment (fp).
So it could, but that would be nasty.
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
