On Thu, 2010-11-11 at 11:13 +0900, Toshiharu Okada wrote:
> This patch adds the USB device driver of EG20T(Topcliff) PCH.
It seems several of the dev_<level> logging messages
need to be terminated with a "\n"
[]
> +static void pch_udc_csr_busy(struct pch_udc_dev *dev)
> +{
> + unsigned int count = 200;
> +
> + /* Wait till idle */
> + while ((pch_udc_readl(dev, UDC_CSR_BUSY_ADDR) & UDC_CSR_BUSY)
> + && --count)
> + cpu_relax();
> + if (!count)
> + dev_err(&dev->pdev->dev, "%s: wait error", __func__);
> +}
[]
> +static void pch_udc_ep_clear_nak(struct pch_udc_ep *ep)
> +{
> + unsigned int loopcnt = 0;
> + struct pch_udc_dev *dev = ep->dev;
> +
> + if (!(pch_udc_ep_readl(ep, UDC_EPCTL_ADDR) & UDC_EPCTL_NAK))
> + return;
> + if (!ep->in) {
> + loopcnt = 10000;
> + while (!(pch_udc_read_ep_status(ep) & UDC_EPSTS_MRXFIFO_EMP) &&
> + --loopcnt)
> + udelay(5);
> + if (!loopcnt)
> + dev_err(&dev->pdev->dev, "%s: RxFIFO not Empty ",
> + __func__);
> + }
> + loopcnt = 10000;
> + while ((pch_udc_read_ep_control(ep) & UDC_EPCTL_NAK) && --loopcnt) {
> + pch_udc_ep_bit_set(ep, UDC_EPCTL_ADDR, UDC_EPCTL_CNAK);
> + udelay(5);
> + }
> + if (!loopcnt)
> + dev_err(&dev->pdev->dev, "%s: Clear NAK not set for ep%d%s",
> + __func__, ep->num, (ep->in ? "in" : "out"));
> +}
etc and several more...
Can you check these and verify the need for newlines at the
end of the formats and add them as appropriate?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
