Re: [PATCH v7] USB device driver of Topcliff PCH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michal

Thank you for your comment.
I will modify.

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
----- Original Message ----- 
Date: Wed, 10 Nov 2010 13:29:58 +0100
From: "MichaÅ Nazarewicz" <m.nazarewicz@xxxxxxxxxxx>
>
> In that case, make it:
>
> if (list_empty(&ep->queue)) {
> if (halt) { /* halt or clear halt */
> if (ep->num == PCH_UDC_EP0)
> ep->dev->stall = 1;
> pch_udc_ep_set_stall(ep);
> pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in, ep->num));
> } else {
> pch_udc_ep_clear_stall(ep);
> }
> ret = 0;
> } else {
> dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
> ret = -EAGAIN;
> }
>
> Ie. no need to put "ret = 0;" twice in the code.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux