On Mon, Nov 08, 2010 at 12:43:02PM +0000, David Vrabel wrote: > Jesper Juhl wrote: > > Hi, > > > > Crashing on a null pointer deref is never a nice thing to do. It seems to > > me that it's better to simply return UWB_RSV_ALLOC_NOT_FOUND if kzalloc() > > fails in uwb_rsv_find_best_allocation(). > > This is fine. > > struct uwb_rsv_alloc_info is not that large (about 414 bytes I think) so > it could possibly go on the stack and avoid the allocation. > > Acked-by: David Vrabel <david.vrabel@xxxxxxx> > > Greg, seeing as I'm not maintaining the UWB subsystem any more do you > want to pick this (and future) UWB patches? Yes, I can do that, and will take this one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html