On Wed, Sep 29, 2010 at 07:55:24AM -0500, tom.leiming@xxxxxxxxx wrote:
From: Ming Lei <tom.leiming@xxxxxxxxx> 1, In Rx double buffer case, FIFO may have two packets, so rxstate should be called to unload fifo if RXPKTRDY is set even the current request has not been completed. 2, Commit 490e5fbe8ccb198fb719ae49eaa0c7071273e016 [usb: musb:gadget: enable autoclear for OUT transfer in both DMA 0 and DMA 1] introduces autoclear to support double buffer in dma mode 0, so remove clearing RXPKTRDY manually for dma mode 0. 3, Felipe's patch[usb: musb: gadget: only enable AUTOCLEAR in double buffered case] may break dma mode 1 for non-doublebuffer endpoint, fix it. With this patch, either usbtest #5 or g_file_storage(writing file to device in usb host) or g_ether have been tested OK in double buffer case(using fifo mode 3). Also, this patch has been verified that single buffer case can't be broken. Cc: Felipe Balbi <balbi@xxxxxx> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Cc: Anand Gadiyar <gadiyar@xxxxxx> Cc: Mike Frysinger <vapier@xxxxxxxxxx> Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> Cc: stable@xxxxxxxxxx Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx> --- This patch is against musb-next branch of Felipe's tree, and is tested on beagle B5.
are we having a new version of this one ?? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
