On Wed, 3 Nov 2010, Larry Finger wrote: > On 11/03/2010 04:04 PM, Alan Stern wrote: > > > > This patch is definitely wrong -- it defeats the entire purpose of > > rewriting the control register! That write was added _specifically_ to > > put the controller into reset, i.e., to change the functional state. > > > > Furthermore, the write does the same thing as ohci_hcd.c does in its > > ohci_usb_reset() routine. Regardless, ohci_run() does a complete host > > controller reset, which should override anything done in pci-quirks.c. > > Perhaps _that_ routine needs some attention. > > It is looking as if your patch is exposing a different bug. When I disable the > write in pci_quirks leaving the controllers in OPER or RESUME mode, then > ohci_run() is not called. I'm still trying to find out why. Is your OHCI controller attached via PCI? If it is, I don't see how ohci_pci_start() can avoid calling ohci_run(). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
