coccinelle check scripts/coccinelle/locks/call_kern.cocci found that
in drivers/usb/host/xhci.c an allocation with GFP_KERNEL is done
with locks held:
xhci_resume
spin_lock_irq(xhci->lock)
xhci_setup_msix
kmalloc(GFP_KERNEL)
Change it to GFP_ATOMIC.
Signed-off-by: David Sterba <dsterba@xxxxxxx>
CC: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
---
Exists in v2.6.37-rc1 and current linux-next
diff -u -p a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c 2010-10-27 11:27:23.534310054 +0200
+++ b/drivers/usb/host/xhci.c 2010-11-02 15:53:03.000000000 +0100
@@ -240,7 +240,7 @@ static int xhci_setup_msix(struct xhci_h
xhci->msix_entries =
kmalloc((sizeof(struct msix_entry))*xhci->msix_count,
- GFP_KERNEL);
+ GFP_ATOMIC);
if (!xhci->msix_entries) {
xhci_err(xhci, "Failed to allocate MSI-X entries\n");
return -ENOMEM;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
