On Tue, Nov 02, 2010 at 04:02:18PM +0200, Felipe Contreras wrote: > On Tue, Nov 2, 2010 at 3:11 PM, Mark Brown > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote: > > > >> config REGULATOR_TWL4030 > >> bool "TI TWL4030/TWL5030/TWL6030/TPS695x0 PMIC" > >> depends on TWL4030_CORE > >> + default y > >> help > >> This driver supports the voltage regulators provided by > >> this family of companion chips. > > > > This default is not suitable for non-OMAP platforms, it should be > > conditional on OMAP or something if we're going to do this (though > > generally we handle this with defconfigs rather than in Kconfig). > > This would only be enabled when TWL4030_CORE is enabled, so non-OMAP > platforms would not get affected. Well, all platforms that have TWL4030_CORE will get REGULATOR_TWL4030 by default, too. (TWL4030_CORE doesn't depend on something omapish.) For me this looks OK. It would be still better if it removed CONFIG_REGULATOR_TWL4030=y from arch/arm/configs/omap2plus_defconfig. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
