Re: ehci-mxc broken [Was: Re: [PATCH] ehci tdi : let's tdi_reset set host mode]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Oct 2010, Uwe Kleine-König wrote:

> This patch (i.e. 65fd42724aee31018b0bb53f4cb04971423be664) broke the build on
> mxc using the mx51_defconfig:
> 
> 	  CC      drivers/usb/host/ehci-hcd.o
> 	In file included from drivers/usb/host/ehci-hcd.c:1166:
> 	drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
> 	drivers/usb/host/ehci-mxc.c:192: error: 'ehci' undeclared (first use in this function)
> 	drivers/usb/host/ehci-mxc.c:192: error: (Each undeclared identifier is reported only once
> 	drivers/usb/host/ehci-mxc.c:192: error: for each function it appears in.)
> 	drivers/usb/host/ehci-mxc.c:117: warning: unused variable 'temp'
> 	make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
> 	make[2]: *** [drivers/usb/host/ehci-hcd.o] Error 2
> 	make[1]: *** [sub-make] Error 2
> 	make: *** [all] Error 2
> 
> It's not obvious for me how to fix it up.  Does anyone care to help me?

It looks that entire "set up the PORTSCx register" section near line
192 belongs inside ehci_mxc_setup() (near the end) instead of
ehci_mxc_drv_probe().

The unused "temp" variable can simply be removed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux