On Mon, Oct 25, 2010 at 02:02:23PM -0400, Mike Frysinger wrote: > On Mon, Oct 25, 2010 at 1:31 PM, Greg KH wrote: > > On Mon, Oct 25, 2010 at 03:10:31AM -0400, Mike Frysinger wrote: > >> We need to eat our own dog food. > > > > I agree, but this patch seems too big. ?I have a different patch > > floating around that did this that seemed less intrusive than this. > > > > One example being: > > > >> -#define USB_DT_DEVICE_QUALIFIER ? ? ? ? ? ? ?0x06 > >> +#define LIBUSB_DT_DEVICE_QUALIFIER ? ? ? ? ? 0x06 > > > > Are these #defines needed to be renamed? ?Is there a namespace > > confusion? > > no, there is no need for it. i can drop these changes if you prefer. Please do. It makes the patch much harder to review and find the parts that really matter for the libusb conversion. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html