On Sat, Oct 23, 2010 at 09:37:47AM -0700, Greg KH wrote: > On Sat, Oct 23, 2010 at 06:20:17PM +0200, Alon Ziv wrote: > > Any module using usb_serial_generic_write (which is already exported) > > had better use usb_serial_generic_write_room as well. > > Are you implying that the one driver using this function today is > broken? Care to provide a patch for it as well? Actually, most usb serial drivers use usb_serial_generic_write as well as usb_serial_generic_write_room. The generic implementations are used unless drivers explicitly define their own. So far there has been no need to export usb_serial_generic_write_room but perhaps Alon's patch does require this. Either way the patch description is thus actually wrong (or rather misleading) as it stands. I'll try to have a look at the other patch tomorrow. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
