Re: [PATCH 0/4] Use USB_ prefix insead of US_

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 07, 2010 at 01:05:20PM +0200, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
> 
> >> Matthew Wilcox <willy@xxxxxxxxxxxxxxx> writes:
> >>> The only thing is that I like your names better than I like the libusual
> >>> names.  I didn't change the libusual names because I didn't want to make
> >>> a big patch.  So instead of this patch, could we add your names to the
> >>> usb/storage.h header file, and then convert libusual to use your names?
> 
> > On Wed, Sep 29, 2010 at 12:31:31PM +0200, Michal Nazarewicz wrote:
> >> This commit changes prefix for USB mass storage class
> >> related macros (ie. USB_SC_ for subclass and USB_PR_ for
> >> class).
> 
> >> Done with:
> >>
> >> 	find -name '*.[ch]' -exec \
> >> 		perl -i -pe 's/\bUS_(SC|PR)_/USB_${1}_/g' {} +
> 
> Greg KH <greg@xxxxxxxxx> writes:
> > I think it might be better to do this by hand, as it broke the build
> > when applied
> 
> I redid the patches and tested on next-20101006.  I did that by first
> reverting the "old" patches:
> 
> 	USB: Move USB Storage definitions to their own header file
> 	USB: Add UAS driver
> 	USB: gadget: file_storage: reuse definitions from a header file
> 
> and applying attached patches.
> 
> I've successfully compiled it with allmodconfig for x86.  I've also
> successfully built and tested file_storage and mass_storage gadgets
> on 2.6.35 on ARM.

Thanks, I've done this and it works great, thanks for fixing this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux