Hi, >-----Original Message----- >From: Balbi, Felipe >Sent: Thursday, October 07, 2010 1:20 PM >To: Kalliguddi, Hema >Cc: Balbi, Felipe; David Brownell; >dbrownell@xxxxxxxxxxxxxxxxxxxxx; Arnaud Mandy; >felipe.balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 2/2] usb: otg: introduce otg_notify_event >and otg_get_last_event > >Hi, > >On Wed, Oct 06, 2010 at 08:11:36AM -0500, Kalliguddi, Hema wrote: >>How about enabling these OTG interrupts(VBUS and ID) only >when the user >>calls like xceiv->otg_init function in the driver probe. In the >>otg_init function call the irq handlers which will catch the >status and >>send the events? With this we can avoid the unnecessary interrupts >>when the user modules are not loaded. > >then you make phy driver depend on link driver. I rather avoid that. > Yes. You are right. this makes the phy driver dependent on link driver/drivers. But is there any role to be played by phy when there is no link driver? Infact I was thinking whether it is good idea to enable the phy interrupts only when the gadget driver is loaded in case of OTG mode. With this we can avoid some more useless notifications to the driver. >I think what Dave is suggesting is that during link's probe() we check >xceiv->state, if it's B_IDLE or A_IDLE then we power up link, if it's >UNKNOWN, keep it powered down. Agree this is good, but this will not avoid the unnecessary interrupts in phy. > >-- >balbi >-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
