--- On Wed, 10/6/10, Martin Fuzzey <mfuzzey@xxxxxxxxx> wrote: > From: Martin Fuzzey <mfuzzey@xxxxxxxxx> > Subject: [PATCH] USB: usbtest: Support gadget zero isochronous configurations > To: "Greg KH" <greg@xxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > Date: Wednesday, October 6, 2010, 8:43 AM > Gadget zero now provides isochronous > endpoints via f_iso; As I said before: NAK on such g_zero mods,or depending on them .. Keep gadget zero as it is, focussed primarily on bulk (and secondarily on control) and tweakable for interrupt transfers. You can update usbtest with ISO support so long as it doesn't interfere with the control and bulk/interrupt tests. I've not looked at this patch enough to know if it would be appropriate for that, presuming you got rid of the "modifies g_zero" pre-req. If you want a gadget specifically to test ISO, go for it -- g_iso, maybe. I suggest that it start by resembling the original userspace ISO tests (using gadgetfs), if it doesn't yet do so. I'm sure some more analysis of ISO failure modes and code coverage would be worth while in terms of turning this stuff into good ISO tests, rather than what someone recently described to me as just "sunny day tests". But matching those original ISO tests would at least provide continuity. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
