Hi Alan, On Tue, Oct 05, 2010 at 01:18:04PM -0400, Alan Stern wrote: > On Tue, 5 Oct 2010, Uwe Kleine-König wrote: > > > ehci_clear_tt_buffer_complete and ehci_endpoint_reset must be used by > > > every EHCI driver. The correct fix is to add them to your driver's > > > hc_driver structure. > > Hmm, if all drivers must have this, why does this callback exist at all? > > All _EHCI_ drivers. Other drivers don't have them. ah, OK, missed that detail of your answer. > > /me continues to dig around ... > > Hmm, usb_hcd_reset_endpoint seems handle .endpoint_reset being NULL. > > That's for backward compatibility. I figured it was better to operate > in a degraded mode than to crash with a NULL pointer exception. :-) Well, I think letting other people's kernel crash is the only way to make them fix their code. This code was introduced by 3444b26afa145 in April 2009. I guess with a NULL pointer exception the last user would have been found earlier. (Note, I didn't check that mxc was the last user.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
