On Tue, 5 Oct 2010, [UTF-8] Uwe Kleine-König wrote:
> - ehci_lpm_check and ehci_lpm_set_da are only used in ehci_update_device
> defined in drivers/usb/host/ehci-pci.c.
> - ehci_adjust_port_wakeup_flags (disguised as
> ehci_prepare_ports_for_controller_suspend and
> ehci_prepare_ports_for_controller_resume) are only used in drivers that
> support suspend and resume. Not all do.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> diff --git a/drivers/usb/host/ehci-lpm.c b/drivers/usb/host/ehci-lpm.c
> index b4d4d63..ceb7bcb 100644
> --- a/drivers/usb/host/ehci-lpm.c
> +++ b/drivers/usb/host/ehci-lpm.c
> @@ -17,7 +17,8 @@
> */
>
> /* this file is part of ehci-hcd.c */
> -static int ehci_lpm_set_da(struct ehci_hcd *ehci, int dev_addr, int port_num)
> +static int __maybe_unused ehci_lpm_set_da(struct ehci_hcd *ehci,
> + int dev_addr, int port_num)
> {
> u32 __iomem portsc;
>
> @@ -37,7 +38,7 @@ static int ehci_lpm_set_da(struct ehci_hcd *ehci, int dev_addr, int port_num)
> * this function is used to check if the device support LPM
> * if yes, mark the PORTSC register with PORT_LPM bit
> */
> -static int ehci_lpm_check(struct ehci_hcd *ehci, int port)
> +static int __maybe_unused ehci_lpm_check(struct ehci_hcd *ehci, int port)
> {
> u32 __iomem *portsc ;
> u32 val32;
Wouldn't it be better simply to move the
#include "ehci-lpm.c"
line into ehci-pci.c (since that's the only place the LPM functions get
used)?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
