On Sun, Oct 03, 2010 at 12:35:07PM -0400, Alan Stern wrote: > On Sun, 3 Oct 2010, tlinder wrote: > > > From: Tatyana Linder <tlinder@xxxxxxxxxxxxxx> > > > > Change ep_choose() and usb_ep_enable() prototypes to use endpoint > > descriptor from usb_ep. This optimization prevents the FDs from handling > > the endpoint chosen descriptor. > > This optimization is not full though. To fully exploit this change one > > needs to update all the UDCs as well since in the current implementation > > each of them saves the endpoint descriptor in it's internal (and extended) > > endpoint structure. > > This patch is a preparation for adding SuperSpeed support to the gadget > > framework. > > > > Signed-off-by: Tatyana Linder <tlinder@xxxxxxxxxxxxxx> > > ... > > > diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c > > index a857b7a..6264fba 100644 > > --- a/drivers/usb/gadget/file_storage.c > > +++ b/drivers/usb/gadget/file_storage.c > > @@ -3,6 +3,7 @@ > > * > > * Copyright (C) 2003-2008 Alan Stern > > * All rights reserved. > > + * Copyright (C) 2010 Code Aurora Forum. All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or without > > * modification, are permitted provided that the following conditions > > Speaking for myself only, I don't think people should add their own > copyright notices in files to which they have not made substantial > changes. A little code motion and a small API adjustment don't seem > like large enough changes to justify this. Some of the other files in > this patch have even smaller changes! I agree. Tatyana, please work with your company's lawyers to properly learn how to add this type of mark to a file in a manner that is correct. Hint, this way is not correct :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html