Hello,
I don't know much about usb drivers in general or ehci, but the warnings
below clutter our auto build logs since quite some time.
Maybe someone can clearify if it's OK for the mxc driver not to use the
functions marked by my patch?!
Best regards
Uwe
--------------------- >8 ---------------------
- ehci_lpm_check and ehci_lpm_set_da are only used in ehci_update_device
defined in drivers/usb/host/ehci-pci.c.
- ehci_adjust_port_wakeup_flags (disguised as
ehci_prepare_ports_for_controller_suspend and
ehci_prepare_ports_for_controller_resume), ehci_clear_tt_buffer_complete
and ehci_endpoint_reset are used in several drivers, but not in ehci-mxc.c
This fixes the following warnings:
drivers/usb/host/ehci-lpm.c:21: warning: 'ehci_lpm_set_da' defined but not used
drivers/usb/host/ehci-lpm.c:41: warning: 'ehci_lpm_check' defined but not used
drivers/usb/host/ehci-q.c:148: warning: 'ehci_clear_tt_buffer_complete' defined but not used
drivers/usb/host/ehci-hcd.c:1088: warning: 'ehci_endpoint_reset' defined but not used
drivers/usb/host/ehci-hub.c:111: warning: 'ehci_adjust_port_wakeup_flags' defined but not used
when compiling with USB_EHCI_MXC.
Cc: Eric BÃnard <eric@xxxxxxxxxx>
Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
Cc: Daniel Mack <daniel@xxxxxxxx>
Cc: Dinh Nguyen <Dinh.Nguyen@xxxxxxxxxxxxx>
Cc: Valentin Longchamp <valentin.longchamp@xxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
---
drivers/usb/host/ehci-hcd.c | 2 +-
drivers/usb/host/ehci-hub.c | 2 +-
drivers/usb/host/ehci-lpm.c | 5 +++--
drivers/usb/host/ehci-q.c | 2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 34a928d..dc1f4ef 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -1083,7 +1083,7 @@ done:
return;
}
-static void
+static void __maybe_unused
ehci_endpoint_reset(struct usb_hcd *hcd, struct usb_host_endpoint *ep)
{
struct ehci_hcd *ehci = hcd_to_ehci(hcd);
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 796ea0c..f636caa 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -106,7 +106,7 @@ static void ehci_handover_companion_ports(struct ehci_hcd *ehci)
ehci->owned_ports = 0;
}
-static void ehci_adjust_port_wakeup_flags(struct ehci_hcd *ehci,
+static void __maybe_unused ehci_adjust_port_wakeup_flags(struct ehci_hcd *ehci,
bool suspending, bool do_wakeup)
{
int port;
diff --git a/drivers/usb/host/ehci-lpm.c b/drivers/usb/host/ehci-lpm.c
index b4d4d63..ceb7bcb 100644
--- a/drivers/usb/host/ehci-lpm.c
+++ b/drivers/usb/host/ehci-lpm.c
@@ -17,7 +17,8 @@
*/
/* this file is part of ehci-hcd.c */
-static int ehci_lpm_set_da(struct ehci_hcd *ehci, int dev_addr, int port_num)
+static int __maybe_unused ehci_lpm_set_da(struct ehci_hcd *ehci,
+ int dev_addr, int port_num)
{
u32 __iomem portsc;
@@ -37,7 +38,7 @@ static int ehci_lpm_set_da(struct ehci_hcd *ehci, int dev_addr, int port_num)
* this function is used to check if the device support LPM
* if yes, mark the PORTSC register with PORT_LPM bit
*/
-static int ehci_lpm_check(struct ehci_hcd *ehci, int port)
+static int __maybe_unused ehci_lpm_check(struct ehci_hcd *ehci, int port)
{
u32 __iomem *portsc ;
u32 val32;
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 233c288..c9859c5 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -143,7 +143,7 @@ qh_refresh (struct ehci_hcd *ehci, struct ehci_qh *qh)
static void qh_link_async(struct ehci_hcd *ehci, struct ehci_qh *qh);
-static void ehci_clear_tt_buffer_complete(struct usb_hcd *hcd,
+static void __maybe_unused ehci_clear_tt_buffer_complete(struct usb_hcd *hcd,
struct usb_host_endpoint *ep)
{
struct ehci_hcd *ehci = hcd_to_ehci(hcd);
--
1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
